FEC 155 - Upgrade all UI Kit packages to React 19 #3034
+4,925
−6,767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByronDWall
requested review from
stephsprinkle,
jaikamat,
ddouglasz,
tylermorrisford and
misama-ct
and removed request for
a team
🦋 Changeset detectedLatest commit: b6abdf9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 99 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ByronDWall
added
the
🚨 🚨 🚨DO NOT MERGE🚨 🚨 🚨
ByronDWall
commented
Jan 8, 2025
| '@commercetools-local/storybook': major | ||
| --- | ||
|
|
||
| Upgrade UI Kit to React 19 |
There was a problem hiding this comment.
I know this should probably more descriptive, suggestions on how much more descriptive are welcome.
There was a problem hiding this comment.
I think it's fine to keep it like this for now. We can come back to it when we are about to release the breaking change version and provide hints with what we will be learning migrating MC applications.
ByronDWall
commented
Jan 8, 2025
CarlosCortizasCT
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
I did a first review and added some comments.
There are also some topics we might want to mark as relevant:
- We're also forcing consumers to update their
react-intldependency to a new major version - We're introducing many changes in tests regarding some type of events (blur, focus,...)
- We're updating
Downshiftto a new major version - We would need to think about how we type icon props in our components
Apart from that, there are also some formatting changes that introduce some noise while reviewing that would be great to avoid.
packages/components/inputs/localized-rich-text-input/src/editor.tsx
Outdated
Show resolved
Hide resolved
packages/components/inputs/select-utils/src/wrapper-with-icon/wrapper-with-icon.tsx
Show resolved
Hide resolved
packages/components/pagination/src/page-size-selector/page-size-selector.tsx
Outdated
Show resolved
Hide resolved
ddouglasz
reviewed
Jan 9, 2025
packages/components/data-table/src/use-manual-column-resizing-reducer.spec.js
Show resolved
Hide resolved
ddouglasz
approved these changes
Jan 9, 2025
kark
reviewed
Jan 9, 2025
kark
reviewed
Jan 10, 2025
packages/components/dropdowns/dropdown-menu/src/dropdown-menu.tsx
Outdated
Show resolved
Hide resolved
packages/components/inputs/rich-text-utils/src/rich-text-body/dropdown.tsx
Outdated
Show resolved
Hide resolved
packages/components/inputs/date-time-input/src/date-time-input.tsx
Outdated
Show resolved
Hide resolved
|
[preview_deployment] |
|
Release workflow succeeded ✅\nSee details: Workflow Run |
ByronDWall
force-pushed
the
preview/fec-155-react-19
branch
from
dec63f3 to
5dda3b6
Compare
ByronDWall
force-pushed
the
preview/fec-155-react-19
branch
2 times, most recently
from
b968ab5 to
cb1c5ec
Compare
…ry/react, etc to v19 or relevant react 19 flavored version, update peerDependencies of react and react-dom from 17.x to 19.x in all affected packages, update test/setup-test-framework to import directly from @testing-library/jest-dom instead of subfolder
ByronDWall
force-pushed
the
preview/fec-155-react-19
branch
from
cb1c5ec to
2a616c9
Compare
|
[preview_deployment] |
|
Release workflow succeeded ✅\nSee details: Workflow Run |
…-system dep from fields and prop-types dep from other components makes rebasing less of a chore in the future
…t maintained anymore, use @hello-pangea/dnd because it is a maintained drop-in replacement for react-beautiful-dnd
|
[preview_deployment] |
|
Release workflow succeeded ✅\nSee details: Workflow Run |
…r to remove react 19 peer dep issues
…irements to 7.x for react19 peer dep compatibility
|
[preview_deployment] |
|
Release workflow succeeded ✅\nSee details: Workflow Run |
…es from react-intl instead of custom props defined in components
|
[preview_deployment] |
|
Release workflow succeeded ✅\nSee details: Workflow Run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 🚨 🚨 DO NOT MERGE - TO BE CONSUMED AS RC VERSION IN DOWNSTREAM REPOS FOR NOW 🚨 🚨 🚨
Available on npm as version
0.0.0-fec-155-react-19-20250122185524Copilots handling this Summary for now
This pull request includes multiple changes to upgrade the UI Kit to React 19 and to simplify the codebase. The most important changes include updating dependencies, removing unnecessary plugins, and refining type definitions.
Upgrade to React 19:
package.jsonfiles. [1] [2] [3] [4] [5] [6] [7]Codebase Simplification:
babel-plugin-typescript-to-proptypesand other unnecessary plugins frombabel.config.js.prop-typesfrom variouspackage.jsonfiles and updated type definitions to use TypeScript. [1] [2] [3] [4] [5] [6]Type Definitions Refinement:
design-system/src/icon-utils.tsanddesign-system/src/theme-provider.tsx. [1] [2] [3] [4]TIconPropstype to@commercetools-uikit/design-systemand updated relevant components. [1] [2] [3] [4]Dependency Updates:
package.jsonfiles, includingformik,patch-package, andreact-intl. [1] [2] [3]Miscellaneous Improvements:
packages/calendar-utils/src/calendar-body/calendar-body.tsxandpackages/calendar-utils/src/calendar-header/calendar-header.tsx. [1] [2] [3] [4] [5] [6]