-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pangolin 3766 localized multiline text field #2794
Pangolin 3766 localized multiline text field #2794
Conversation
🦋 Changeset detectedLatest commit: b165b2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 96 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Do not merge this until the dependent pr is merged. |
This PR has the same height issue as the Input PR. Although oddly here I can't refresh storybook with isCondensed checked and have it render correctly on the first time for any fields that are on the page (it will render correctly the additional field after showing additional languages). |
ff430b3
to
e45a1f4
Compare
e45a1f4
to
cb8af66
Compare
b3b7692
to
31d1d83
Compare
a802b56
to
6f85bf9
Compare
…perty on LocalizedMultilineTextInput
…based on whether isCondensed value has been toggled
…exposed on LocalizedMultilineTextInput
…p on LocalizedMultilineTextField
…ocalizedMultilineTextField component to allow resizing height when isCondensed toggles
…acheMeasurements, change storybook default value to true, add default value in component
e9e5209
to
e87a950
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks, Sarah 👍
Summary
Update the LocalizedMultilineTextField component to support an isCondensed and cacheMeasurements property that is passed down to the LocalizedMultilineTextInput to display the condensed layout.
Description
Figma Design
Results