Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Kit | FE | Date / Time Inputs add new isCondensed prop #2790

Merged
merged 9 commits into from
Apr 24, 2024

Conversation

jmcreasman
Copy link
Contributor

@jmcreasman jmcreasman commented Apr 22, 2024

Adding a new boolean isCondensed prop that when set to true condenses the input height, font size and icon size for the following four components:

DateInput

isCondensed = false
Screenshot 2024-04-22 at 14 02 01

isCondensed = true
Screenshot 2024-04-22 at 14 02 13

DateRangeInput

isCondensed = false
Screenshot 2024-04-23 at 13 19 07

isCondensed = true
Screenshot 2024-04-23 at 13 19 14

TimeInput

isCondensed = false
Screenshot 2024-04-23 at 13 19 49

isCondensed = true
Screenshot 2024-04-23 at 13 20 00

DateTimeInput

isCondensed = false
Screenshot 2024-04-23 at 13 20 26

isCondensed = true
Screenshot 2024-04-23 at 13 20 34

@jmcreasman jmcreasman requested a review from a team April 22, 2024 18:17
Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 0d67501

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 96 packages
Name Type
@commercetools-uikit/date-range-input Minor
@commercetools-uikit/date-time-input Minor
@commercetools-uikit/date-input Minor
@commercetools-uikit/time-input Minor
@commercetools-uikit/calendar-utils Minor
@commercetools-uikit/date-range-field Minor
@commercetools-uikit/inputs Minor
@commercetools-uikit/date-time-field Minor
@commercetools-uikit/date-field Minor
@commercetools-uikit/time-field Minor
@commercetools-uikit/fields Minor
@commercetools-frontend/ui-kit Minor
@commercetools-uikit/design-system Minor
@commercetools-uikit/calendar-time-utils Minor
@commercetools-uikit/hooks Minor
@commercetools-uikit/i18n Minor
@commercetools-uikit/localized-utils Minor
@commercetools-uikit/utils Minor
@commercetools-uikit/accessible-hidden Minor
@commercetools-uikit/avatar Minor
@commercetools-uikit/card Minor
@commercetools-uikit/collapsible-motion Minor
@commercetools-uikit/collapsible-panel Minor
@commercetools-uikit/collapsible Minor
@commercetools-uikit/constraints Minor
@commercetools-uikit/data-table-manager Minor
@commercetools-uikit/data-table Minor
@commercetools-uikit/field-errors Minor
@commercetools-uikit/field-label Minor
@commercetools-uikit/field-warnings Minor
@commercetools-uikit/grid Minor
@commercetools-uikit/icons Minor
@commercetools-uikit/label Minor
@commercetools-uikit/link Minor
@commercetools-uikit/loading-spinner Minor
@commercetools-uikit/messages Minor
@commercetools-uikit/notifications Minor
@commercetools-uikit/pagination Minor
@commercetools-uikit/primary-action-dropdown Minor
@commercetools-uikit/progress-bar Minor
@commercetools-uikit/stamp Minor
@commercetools-uikit/tag Minor
@commercetools-uikit/text Minor
@commercetools-uikit/tooltip Minor
@commercetools-uikit/view-switcher Minor
@commercetools-uikit/accessible-button Minor
@commercetools-uikit/flat-button Minor
@commercetools-uikit/icon-button Minor
@commercetools-uikit/link-button Minor
@commercetools-uikit/primary-button Minor
@commercetools-uikit/secondary-button Minor
@commercetools-uikit/secondary-icon-button Minor
@commercetools-uikit/dropdown-menu Minor
@commercetools-uikit/async-creatable-select-field Minor
@commercetools-uikit/async-select-field Minor
@commercetools-uikit/creatable-select-field Minor
@commercetools-uikit/localized-multiline-text-field Minor
@commercetools-uikit/localized-text-field Minor
@commercetools-uikit/money-field Minor
@commercetools-uikit/multiline-text-field Minor
@commercetools-uikit/number-field Minor
@commercetools-uikit/password-field Minor
@commercetools-uikit/radio-field Minor
@commercetools-uikit/search-select-field Minor
@commercetools-uikit/select-field Minor
@commercetools-uikit/text-field Minor
@commercetools-uikit/async-creatable-select-input Minor
@commercetools-uikit/async-select-input Minor
@commercetools-uikit/checkbox-input Minor
@commercetools-uikit/creatable-select-input Minor
@commercetools-uikit/input-utils Minor
@commercetools-uikit/localized-money-input Minor
@commercetools-uikit/localized-multiline-text-input Minor
@commercetools-uikit/localized-rich-text-input Minor
@commercetools-uikit/localized-text-input Minor
@commercetools-uikit/money-input Minor
@commercetools-uikit/multiline-text-input Minor
@commercetools-uikit/number-input Minor
@commercetools-uikit/password-input Minor
@commercetools-uikit/radio-input Minor
@commercetools-uikit/rich-text-input Minor
@commercetools-uikit/rich-text-utils Minor
@commercetools-uikit/search-select-input Minor
@commercetools-uikit/search-text-input Minor
@commercetools-uikit/select-input Minor
@commercetools-uikit/select-utils Minor
@commercetools-uikit/selectable-search-input Minor
@commercetools-uikit/text-input Minor
@commercetools-uikit/toggle-input Minor
@commercetools-uikit/spacings-inline Minor
@commercetools-uikit/spacings-inset-squish Minor
@commercetools-uikit/spacings-inset Minor
@commercetools-uikit/spacings-stack Minor
@commercetools-uikit/buttons Minor
@commercetools-uikit/spacings Minor
visual-testing-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 1:24pm

Copy link
Contributor

@ddouglasz ddouglasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you 🙌🏽

Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmcreasman 👍

Copy link
Contributor

@chloe0592 chloe0592 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jmcreasman
Copy link
Contributor Author

jmcreasman commented Apr 23, 2024

@CarlosCortizasCT It looks like some of the other Date/Time related input can all be done in the same PR as the bulk of the work is already done here and they just need to pass in the isCondensed prop. If merging this PR can be held off until I've done that I figure it would be preferable than multiple PRs to be reviewed. Thanks!

@CarlosCortizasCT
Copy link
Contributor

@CarlosCortizasCT It looks like some of the other Date/Time related input can all be done in the same PR as the bulk of the work is already done here and they just need to pass in the isCondensed prop. If merging this PR can be held off until I've done that I figure it would be preferable than multiple PRs to be reviewed. Thanks!

Sure! I think that's a great idea 👍

@jmcreasman jmcreasman changed the title UI Kit | FE | DateInput add new isCondensed prop UI Kit | FE | Date / Time Inputs add new isCondensed prop Apr 23, 2024
@jmcreasman
Copy link
Contributor Author

Ok, added the other three and this is ready for any additional review again.

@@ -0,0 +1,6 @@
---
'@commercetools-uikit/date-input': minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the changeset to include all the components that have been updated? 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarlosCortizasCT sorry about that, edited and pushed the updated changeset now

@ddouglasz ddouglasz merged commit cd9c9b0 into main Apr 24, 2024
7 checks passed
@ddouglasz ddouglasz deleted the PANGOLIN-3741-date-input-add-is-condensed-prop branch April 24, 2024 13:29
@ct-changesets ct-changesets bot mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants