-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Kit | FE | Date / Time Inputs add new isCondensed prop #2790
UI Kit | FE | Date / Time Inputs add new isCondensed prop #2790
Conversation
🦋 Changeset detectedLatest commit: 0d67501 The changes in this PR will be included in the next version bump. This PR includes changesets to release 96 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thank you 🙌🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jmcreasman 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@CarlosCortizasCT It looks like some of the other Date/Time related input can all be done in the same PR as the bulk of the work is already done here and they just need to pass in the isCondensed prop. If merging this PR can be held off until I've done that I figure it would be preferable than multiple PRs to be reviewed. Thanks! |
Sure! I think that's a great idea 👍 |
Ok, added the other three and this is ready for any additional review again. |
@@ -0,0 +1,6 @@ | |||
--- | |||
'@commercetools-uikit/date-input': minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the changeset to include all the components that have been updated? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarlosCortizasCT sorry about that, edited and pushed the updated changeset now
Adding a new boolean isCondensed prop that when set to true condenses the input height, font size and icon size for the following four components:
DateInput
isCondensed = false
isCondensed = true
DateRangeInput
isCondensed = false
isCondensed = true
TimeInput
isCondensed = false
isCondensed = true
DateTimeInput
isCondensed = false
isCondensed = true