Pangolin 3712 select field #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: faa117f The changes in this PR will be included in the next version bump. This PR includes changesets to release 96 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sarah4VT
force-pushed
the
PANGOLIN-3712-select-field
branch
from
2663463 to
da137bc
Compare
…onal condensed view
…add visual spec for new isCondensed prop
…nd icon left smaller in condensed mode
Sarah4VT
force-pushed
the
PANGOLIN-3712-select-field
branch
from
da137bc to
522e0ba
Compare
Sarah4VT
requested review from
a team,
CarlosCortizasCT,
jmcreasman,
kterry1 and
valoriecarli
and removed request for
a team
CarlosCortizasCT
approved these changes
Apr 17, 2024
FilPob
approved these changes
Apr 17, 2024
Merged
ddouglasz
pushed a commit
that referenced
this pull request
Apr 17, 2024
* feat(select-input): update styling of select input component for optional condensed view * feat(select-input): update types to be more dynamic/maintainable and add visual spec for new isCondensed prop * feat(select-input): update text for isCondensed in readme * feat(select-input): make multi tag remove button, multi tag height, and icon left smaller in condensed mode * feat(select-field): add isCondensed layout for SelectField component * feat(select-field): undo change I didn't mean to do and may have been a merge conflict I handled incorrectly * feat(select-field): remove duplicate code that came from a bad merge * feat(select-field): update typo in readme * feat(select-field): update typo in readme * refactor(select-field): update readmes * refactor(select-field): restore original comment format --------- Co-authored-by: Carlos Cortizas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Update the select field component to support an isCondensed property that is passed down to the Select Input to display the condensed layout.