test: clientcredentials instance

commercetools · Jan 21, 2025 · 8d31291 · 8d31291
1 parent eb01ef2
commit 8d31291
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/commercetools-base/src/Client/ClientCredentials.php b/lib/commercetools-base/src/Client/ClientCredentials.php
@@ -32,13 +32,13 @@ class ClientCredentials
      *   The client id.
      * @param string $clientSecret
      *   The client secret.
-     * @param string $scope
+     * @param ?string $scope
      *   Provide the scope when you want to request a specific ones for the client.
      *   Can be omitted to use all scopes of the oauth client.
      *   Format: `<the scope name>:<the project key>`.
      *   Example: `manage_products:project1`.
      */
-    public function __construct(string $clientId, string $clientSecret, ?string $scope)
+    public function __construct(string $clientId, string $clientSecret, ?string $scope = null)
     {
         $this->clientId = $clientId;
         $this->clientSecret = $clientSecret;

diff --git a/test/unit/MiscTest.php b/test/unit/MiscTest.php
@@ -37,6 +37,7 @@
 use Commercetools\Api\Models\Type\TypeReferenceBuilder;
 use Commercetools\Api\Models\Type\TypeResourceIdentifierBuilder;
 use Commercetools\Base\JsonObject;
+use Commercetools\Client\ClientCredentials;
 use Commercetools\Client\ClientFactory;
 use GuzzleHttp\Psr7\Response;
 use PHPUnit\Framework\TestCase;
@@ -289,4 +290,11 @@ public function testAddressDraft()
             json_encode($cart)
         );
     }
+
+
+    public function testCredentials()
+    {
+        $credentials = new ClientCredentials("clientId", "clientSecret");
+        $this->assertInstanceOf(ClientCredentials::class, $credentials);
+    }
 }