Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVX-513] configurable protocol version for HTTP clients #804

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

jenschude
Copy link
Contributor

  • Changeset added

Features

Fixes

Breaking changes

@jenschude jenschude requested a review from a team as a code owner January 21, 2025 20:25
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 6.00000% with 47 lines in your changes missing coverage. Please review.

Project coverage is 10.07%. Comparing base (1775bc8) to head (40b2fa0).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...mercetools/http/apachehttp/CtApacheHttpClient.java 6.45% 29 Missing ⚠️
...om/commercetools/http/netty/CtNettyHttpClient.java 0.00% 15 Missing ⚠️
...ommercetools/http/javanet/CtJavaNetHttpClient.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #804      +/-   ##
============================================
- Coverage     10.08%   10.07%   -0.01%     
- Complexity     1951     1952       +1     
============================================
  Files          6895     6895              
  Lines         67204    67249      +45     
  Branches        282      282              
============================================
- Hits           6780     6778       -2     
- Misses        60247    60294      +47     
  Partials        177      177              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenschude jenschude changed the title configurable protocol version for HTTP clients [DEVX-513] configurable protocol version for HTTP clients Jan 22, 2025
@kodiakhq kodiakhq bot merged commit 01bd9a8 into main Jan 22, 2025
12 of 13 checks passed
@kodiakhq kodiakhq bot deleted the configure-http-version branch January 22, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant