Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize CI setup to <20s #34123

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vishwamartur
Copy link

Related to #30706

Optimize the setup-with-retry stage in CI jobs to finish in less than 20 seconds.

  • Dockerfile.openpilot_base

    • Split the installation of Python dependencies into smaller layers to improve download concurrency.
    • Add comments to explain the changes made.
  • .github/workflows/setup-with-retry/action.yaml

    • Reduce the sleep time between retries to 5 seconds.
    • Add a step to cache Python dependencies using GitHub Actions cache.
  • .github/workflows/setup/action.yaml

    • Add a step to restore the Python dependencies cache.
    • Add a step to save the Python dependencies cache.

Related to commaai#30706

Optimize the `setup-with-retry` stage in CI jobs to finish in less than 20 seconds.

* **Dockerfile.openpilot_base**
  - Split the installation of Python dependencies into smaller layers to improve download concurrency.
  - Add comments to explain the changes made.

* **.github/workflows/setup-with-retry/action.yaml**
  - Reduce the sleep time between retries to 5 seconds.
  - Add a step to cache Python dependencies using GitHub Actions cache.

* **.github/workflows/setup/action.yaml**
  - Add a step to restore the Python dependencies cache.
  - Add a step to save the Python dependencies cache.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@adeebshihadeh
Copy link
Contributor

Looks like this is still a WIP? First one I checked is >1m
image

@adeebshihadeh adeebshihadeh marked this pull request as draft November 28, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants