Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uploader: use context manager for response handling #34117

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

uploader: use context manager for response handling #34117

wants to merge 3 commits into from
+37 −27

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Nov 27, 2024 •
edited
Loading

  1. auto-close Response using with
  2. add __enter__ and __exit__ to FakeResponse and MockResponse, to support the new with usage.

@deanlee deanlee changed the title uploader: ensure auto-close of response using context manager uploader: use context manager for response handling Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deanlee