Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Debug Bridge Toggle #34092

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

amoghmunikote
Copy link

@amoghmunikote amoghmunikote commented Nov 23, 2024

This PR is for #34041 (just a milestone for the bounty).

Current list of things required for bounty

  • Add toggle into developer menu
  • Make toggle persistent
  • Enable it during setup
  • Make ADB work over USB
  • Cleanup code and condense it

For the sake of a concise recap, does the bounty require ADB to work over USB?

@amoghmunikote amoghmunikote marked this pull request as ready for review November 23, 2024 04:09
@amoghmunikote
Copy link
Author

Sorry, I did not mean to mark it ready for review. Please revert it to the original state.

Copy link
Contributor

github-actions bot commented Nov 23, 2024

UI Preview

settings_developer : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
All Screenshots

@maxime-desroches maxime-desroches marked this pull request as draft November 23, 2024 04:19
@adeebshihadeh
Copy link
Contributor

For the sake of a concise recap, does the bounty require ADB to work over USB?

Yes, that's the whole point. This also requires an accompanying agnos-builder PR to make it all work like SSH.

@amoghmunikote
Copy link
Author

Ok, I am just checking. I will link a PR for agnos builder soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants