Switch to nlohmann/json from json11 #31093
Conversation
| @@ -39,26 +39,25 @@ void recv_log(int thread_cnt, int thread_msg_cnt) { | |||
|
|
|||
| REQUIRE(buf[0] == CLOUDLOG_DEBUG); | |||
There was a problem hiding this comment.
This test fail, but I'm not sure why it's here in the first place. If you got a JSON as a string, then buf[0] should be '{' right ?
There was a problem hiding this comment.
see
Line 94 in 78e20cf
This change should be well-tested by our CI. The last remaining json11 usage is in selfdrive/modeld/thneed. That doesn't build by default on PC, but you can build it with |
|
Thanks, will do asap |
|
@adeebshihadeh I hope it's good, it does compile and pass the CI |
adeebshihadeh
changed the title
|
Thanks! Want to try #26739? It might be even easier than this one. |
This reverts commit ee03648.
This reverts commit 88757c1.
Description
This is a work in progress to switch to a new JSON library. From json11 to nlohmann/json.
#24523
Verification
I do not posses any hardware so my testing capabilities are quite limited. However the CI and Unit test can give a good indicator.
Some tests in the driving simulator might also be a good idea.