Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure custom paths are used during startup #5794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure custom paths are used during startup #5794

wants to merge 1 commit into from
+21 −21

Conversation

webfiltered
Copy link
Contributor

Current:

  • User dir from folder_paths is accessed during class instantiation of UserManagement (via PromptServer)
  • If in a protected folder (e.g. Program Files), this causes access denied errors pre-startup

Proposed:

  • Configure folder_paths from args & yaml earlier in the main process

Unresolved:

  • If there is no input dir in the same location as main.py, an attempt to create it will still be made during folder_paths import

Edits welcome!

@webfiltered
Ensure custom paths are used during startup
3dd7489 
Normal paths are accessed during class instantiation.  Setting folder paths from arguments early in the process prevents default paths from being created.

If "input" dir is not a sibling of main.py, an attempt to create it will still be made when folder_paths is imported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous comfyanonymous is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@webfiltered