Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expecty macro #307

Merged
merged 3 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build.sc
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ object Deps {
val geny = ivy"com.lihaoyi::geny::1.1.1"
val sourcecode = ivy"com.lihaoyi::sourcecode::0.4.2"
val utest = ivy"com.lihaoyi::utest::0.8.4"
val expecty = ivy"com.eed3si9n.expecty::expecty::0.16.0"
def scalaReflect(scalaVersion: String) = ivy"org.scala-lang:scala-reflect:$scalaVersion"
def scalaLibrary(version: String) = ivy"org.scala-lang:scala-library:${version}"
}
Expand Down Expand Up @@ -164,6 +165,7 @@ object os extends Module {
object jvm extends Cross[OsJvmModule](scalaVersions)
trait OsJvmModule extends OsModule with MiMaChecks {
object test extends ScalaTests with OsLibTestModule {
override def ivyDeps = T{super.ivyDeps() ++ Agg(Deps.expecty)}

// we check the textual output of system commands and expect it in english
def forkEnv = super.forkEnv() ++ Map(
Expand Down
8 changes: 3 additions & 5 deletions os/src-3/Macros.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package os

import os.PathChunk.{RelPathChunk, StringPathChunk, segmentsFromStringLiteralValidation}
import os.PathChunk.{RelPathChunk, StringPathChunk, segmentsFromString, segmentsFromStringLiteralValidation}
import os.RelPath.fromStringSegments

import scala.quoted.{Expr, Quotes}
Expand All @@ -20,11 +20,9 @@ object Macros {

s.asTerm match {
case Inlined(_, _, Literal(StringConstant(literal))) =>
val stringSegments = segmentsFromStringLiteralValidation(literal)
segmentsFromStringLiteralValidation(literal)
'{
new RelPathChunk(fromStringSegments(${
Expr(stringSegments)
}))
new RelPathChunk(fromStringSegments(segmentsFromString($s)))
}
case _ =>
'{
Expand Down
4 changes: 2 additions & 2 deletions os/src/Path.scala
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ trait StringPathChunkConversion {
}

object PathChunk extends PathChunkMacros {
private[os] def segmentsFromString(s: String): Array[String] = {
def segmentsFromString(s: String): Array[String] = {
val trailingSeparatorsCount = s.reverseIterator.takeWhile(_ == '/').length
val strNoTrailingSeps = s.dropRight(trailingSeparatorsCount)
val splitted = strNoTrailingSeps.split('/')
splitted ++ Array.fill(trailingSeparatorsCount)("")
}

private[os] def segmentsFromStringLiteralValidation(literal: String) = {
private[os] def segmentsFromStringLiteralValidation(literal: String): Array[String] = {
val stringSegments = segmentsFromString(literal)
val validSegmnts = validLiteralSegments(stringSegments)
val sanitizedLiteral = validSegmnts.mkString("/")
Expand Down
33 changes: 33 additions & 0 deletions os/test/src-jvm/ExpectyIntegration.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package test.os

import os._
import utest._
import com.eed3si9n.expecty.Expecty.expect

object ExpectyIntegration extends TestSuite {
val tests = Tests {
test("Literals") {
test("Basic") {
expect(rel / "src" / "Main/.scala" == rel / "src" / "Main" / ".scala")
expect(root / "core/src/test" == root / "core" / "src" / "test")
expect(root / "core/src/test" == root / "core" / "src/test")
}
test("literals with [..]") {
expect(rel / "src" / ".." == rel / "src" / os.up)
expect(root / "src/.." == root / "src" / os.up)
expect(root / "src" / ".." == root / "src" / os.up)
expect(root / "hello" / ".." / "world" == root / "hello" / os.up / "world")
expect(root / "hello" / "../world" == root / "hello" / os.up / "world")
expect(root / "hello/../world" == root / "hello" / os.up / "world")
}
test("from issue") {
expect(Seq(os.pwd / "foo") == Seq(os.pwd / "foo"))
val path = os.Path("/") / "tmp" / "foo"
expect(path.startsWith(os.Path("/") / "tmp"))
}
test("multiple args") {
expect(rel / "src" / ".." == rel / "src" / os.up, root / "src/.." == root / "src" / os.up)
}
}
}
}
1 change: 1 addition & 0 deletions os/test/src/PathTests.scala
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ object PathTests extends TestSuite {
assert(root / "core/src/test" == root / "core" / "src/test")
}
test("literals with [..]") {

assert(rel / "src" / ".." == rel / "src" / os.up)
assert(root / "src/.." == root / "src" / os.up)
assert(root / "src" / ".." == root / "src" / os.up)
Expand Down