Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check performance of new translate to dict #1284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

collerek
Copy link
Owner

No description provided.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5f4354d) to head (a6d0c30).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1284   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          203       203           
  Lines        14806     14803    -3     
=========================================
- Hits         14806     14803    -3     
Files Coverage Δ
ormar/queryset/utils.py 100.00% <100.00%> (ø)

Copy link

codspeed-hq bot commented Mar 25, 2024

CodSpeed Performance Report

Merging #1284 will degrade performances by 12.22%

Comparing change-translate-list-to-dict (a6d0c30) with master (5f4354d)

Summary

⚡ 3 improvements
❌ 1 regressions
✅ 80 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master change-translate-list-to-dict Change
test_avg[1000] 16.3 ms 14.7 ms +11.32%
test_exists[250] 11.9 ms 13.5 ms -12.22%
test_first[1000] 14.2 ms 12.8 ms +11.51%
test_get_or_none[1000] 14.1 ms 11.5 ms +22.89%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant