allow multiple organize calls in an organizer #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laserlemon
requested changes
Mar 26, 2017
lib/interactor/organizer.rb
Outdated
| # end | ||
| # | ||
| # Returns nothing. | ||
| def organize(*interactors) | ||
| @organized = interactors.flatten | ||
| @organized ||= [] |
There was a problem hiding this comment.
This already happens on line 66/68.
lib/interactor/organizer.rb
Outdated
| # end | ||
| # | ||
| # Returns nothing. | ||
| def organize(*interactors) | ||
| @organized = interactors.flatten | ||
| @organized ||= [] | ||
| @organized += interactors.flatten |
There was a problem hiding this comment.
Rather than using +=, we could concat which won't duplicate the array in memory.
There was a problem hiding this comment.
def organize(*interactors)
organized.concat(interactors.flatten)
end
hedgesky
force-pushed
the
allow_multiple_organize_calls_in_an_organizer
branch
from
92656c0 to
d9de996
Compare
|
I've made the following change: - @organized ||= []
- @organized += interactors.flatten
+ organized.concat(interactors.flatten)Fixed up already existing commit. |
hedgesky
force-pushed
the
allow_multiple_organize_calls_in_an_organizer
branch
from
d9de996 to
aaa2bb6
Compare
|
@hedgesky I made a mess of this trying to resolve conflicts in the web interface. Could you please rebase this against |
hedgesky
force-pushed
the
allow_multiple_organize_calls_in_an_organizer
branch
from
675b049 to
5d28fbe
Compare
|
Done. |
laserlemon
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #127.