Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plone.volto is ZCML-included but nowhere imported #2

Open
tobiasherp opened this issue Mar 7, 2024 · 1 comment
Open

plone.volto is ZCML-included but nowhere imported #2

tobiasherp opened this issue Mar 7, 2024 · 1 comment

Comments

@tobiasherp
Copy link

In dependencies.zcml, there is an unconditional <include package="plone.volto" /> statement;
in classic UI installations however, plone.volto is not needed, and is often omitted to avoid accidental activation (which would break the site).

I couldn't find any other references to plone.volto in the code; can this line be simply removed?

If it still fulfils a purpose, it should at least be conditional (and perhaps commented).

@davisagli
Copy link
Member

I think you're right that it's not actually a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants