Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associated Authority Field Prefix #201

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Adds assoc prefix to associated authorities fields

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1286

This helps with fields in the schema which may have the same name, e.g. chronologies_common.chronologyNote and assocCronlogyAuthGroupList/assocChronologyAuthGroup.chronlogyNote. By adding a prefix we're removing the possibility of this collision, as we will have assocChronlogyAuthGroupList/assocChronologyAuthGroup.assocChronlogyNote.

How should this be tested? Do these changes have associated tests?

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested against a local instance

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.44%. Comparing base (e04eb31) to head (0908f0d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files         555      555           
  Lines       10899    10899           
  Branches     1196     1196           
=======================================
  Hits        10403    10403           
  Misses        147      147           
  Partials      349      349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ray-lee ray-lee merged commit 543db7a into collectionspace:master Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants