Add CountingBloomFilter #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Love this gem but needed a counting filter for some operations that required decrementing from filter. Took the existing ContinuousBloomFilter and refactored to implement counters. __Notes__ * Added spec tests but have not touched the benchmarks * Allows you to pass counter limit in decimal and will use log2 to find a suitable bit bucket size * Grants control of roll over behavior with counters with `#new` * Easy to implement simple add/remove existence with `#set(key, 1)` and `#clear(key)`. #include(key) will respond with `counter > 0` __Questions__ * Did not implement mutexes like ContinuousBloomFilter, not sure if thread safety is am issue yet with this new class
|
Great contribution! Thanks! I am traveling until Aug 20th and will review/merge this when I come back! |
|
Any news on this? |
|
yikes, this fell in a crack, sorry about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love this gem but needed a counting filter for some operations that required decrementing from filter.
Took the existing ContinuousBloomFilter and refactored to implement counters.
Notes
#new#add(key)and#clear(key).#include(key)will respond withcounter > 0(true | false).Questions