Add sleep mode #94
Closed
Add sleep mode #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 22, 2024 10:54
bezineb5
commented
Jun 22, 2024
| @@ -40,13 +40,6 @@ | |||
| print(e.args) | |||
| traceback.print_exc() | |||
|
|
|||
| try: | |||
| qnap.get_external_drive() | |||
bezineb5
commented
Jun 22, 2024
| @@ -50,7 +50,6 @@ def _init_session(self): | |||
| if self._login() is False: | |||
| self._session_error = True | |||
| self._debuglog("Login failed, unable to process request") | |||
| return | |||
There was a problem hiding this comment.
pylint was failing on this useless return
bezineb5
commented
Jun 22, 2024
|
|
||
| def file_get_contents(directory, file): | ||
| file = os.path.join(response_directory, directory, file) | ||
| if not os.path.exists(file): | ||
| return None | ||
|
|
||
| with open(file, 'r') as myfile: |
There was a problem hiding this comment.
The linter was unhappy about the encoding
bezineb5
commented
Jun 22, 2024
| @@ -19,7 +22,7 @@ setenv = | |||
| LANG=C.UTF-8 | |||
| PYTHONPATH = {toxinidir}:{toxinidir}/qnapstats | |||
| commands = | |||
| flake8 | |||
There was a problem hiding this comment.
It was testing all installed packages
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
put_in_sleep_modemethod. This puts the QNAP NAS in sleep mode.Also updated tox tests.
This is tested on a QNAP TS-251+ with QTS 5.1.7.2770.