Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate/flip layers #3

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Rotate/flip layers #3

wants to merge 3 commits into from

Conversation

mrbig
Copy link
Collaborator

@mrbig mrbig commented Feb 6, 2015

Hi, I've added the feature to be able to rotate/flip layers. Please take a look at my code, and if you like it, then I'll clean this up a bit before merge (updating documentation, tests, etc)

@coldume
Copy link
Owner

coldume commented Feb 6, 2015

Does this work for animated GIF?

@mrbig
Copy link
Collaborator Author

mrbig commented Feb 6, 2015

Hi, I've updated the Gif Engine also, did work for me as expected.

I still have a problem: order of actions could be important when combining rotation and flip, but the current parametrized bag implementation is unaware of that. So this might would need some changes down there also. For now rotation is always executed as first, resample as next, and flip as last.

@coldume
Copy link
Owner

coldume commented Feb 7, 2015

Imagecraft project is started when my website need to manipulate avatars that users upload, so this is why I forgot to add rotate/flip features to imagecraft.

My code is very complex, especially the GIF part. I‘ve never thought someone could understand my code and add any new feature to it. Anyway, very great job, I have added you as an imagecraft collaborator, you can merge pull request yourself if you think everything is ok.

Also, to solve the order of actions problem, you can combine flip/rotate to one feature: transform(int $rotate, bool $flip), the image must rotate first, then flip.

@DFoxinator
Copy link

DFoxinator commented May 18, 2016

Rotate would be a great feature, any chance this will get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants