#3156 = do not transform abstract

coiouhkc · Jun 17, 2023 · acb5cf5 · acb5cf5
1 parent 28581b0
commit acb5cf5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/rewrite-java/src/main/java/org/openrewrite/java/LombokUtilityClass.java b/rewrite-java/src/main/java/org/openrewrite/java/LombokUtilityClass.java
@@ -138,6 +138,9 @@ public J.ClassDeclaration visitClassDeclaration(
                 final J.ClassDeclaration classDecl,
                 final AtomicBoolean shouldPerformChanges
         ) {
+            if (classDecl.hasModifier(J.Modifier.Type.Abstract)) {
+                shouldPerformChanges.set(false);
+            }
             if (classDecl.getLeadingAnnotations().stream().anyMatch(a -> "UtilityClass".equals(a.getSimpleName()))) {
                 shouldPerformChanges.set(false);
             }

diff --git a/rewrite-java/src/test/java/org/openrewrite/java/LombokUtilityClassTest.java b/rewrite-java/src/test/java/org/openrewrite/java/LombokUtilityClassTest.java
@@ -26,7 +26,6 @@
  * - Interfaces
  * - Empty classes & interfaces
  * - inheritance
- * - abstract classes
  * - instantiations of changed classes
  * - constructor
  */
@@ -266,6 +265,21 @@ public static void main(String[] args) {
             );
         }
 
+        @Test
+        void givenAbstractClass() {
+            rewriteRun(
+                    recipeSpec -> recipeSpec.recipe(new LombokUtilityClass()),
+                    java(
+                            """
+                                    public abstract class A {
+                                       public static void doSmth() {
+                                       };
+                                    }
+                                    """
+                    )
+            );
+        }
+
     }
 
     @Test