Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Examples to make them run against current API with modern Python. #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Hello1024
Copy link

See commit messages for each change.

Copy link

@dlefcoe dlefcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both the changes are good.

However, line 66 coinfloor.GetBalances() throws an error:
Exception has occurred: TypeError _err_handler() takes 2 positional arguments but 3 were given

check: if this is commented out, then the code runs again.

@Hello1024
Copy link
Author

Hello1024 commented Feb 25, 2021

Please take another look. Note that you were probably trying to use the old v1 api (which no longer allows logins, hence throwing an error) rather than v2.

@dlefcoe
Copy link

dlefcoe commented Feb 25, 2021

I am trying to modify the code for v2, but it is not clear what to enter for the credentials in order to complete the test. The are 4 parameters i have attached in the image from the Your Coinfloor Exchange API authentication credentials screen of the webpage.

login_credentials

URL:

is this the correct URL ? wss://api.coinfloor.co.uk/

The core_id of the user:

presumably this is what i have labelled (in red) as some_user_id as is parsed as an integer ?

The cookie, a.k.a API key:

which value (in the red boxes) is this please ?

passphrase:

where does the user get the passphrase from ?
(is it one of the values in the red box?)

@Hello1024
Copy link
Author

Hello1024 commented Feb 27, 2021

I used the code with no further modifications with v2 just fine...

Run it like this:

python3 clientExample.py -i Some_user_ID -c some_long_cookie_1234 -p YourLoginPassword wss://apiv2.coinfloor.co.uk/

Note that currently v2 seems to work just fine with the v1 cookie. The password is the login password to the coinfloor website.

@dlefcoe
Copy link

dlefcoe commented Mar 2, 2021

this works.

ammended:
website = wss://apiv2.coinfloor.co.uk/
password to the website login password.

Thanks. Can commit to the master now.

@Hello1024
Copy link
Author

Only those with write access to this repository can merge pull requests.

We need someone with write access...

@dlefcoe
Copy link

dlefcoe commented May 12, 2021

Additional question.

how can the user watch to see if a trade is executed ?

presumably it is one of the available methods, so where can one find a list of all of the methods please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants