-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Examples to make them run against current API with modern Python. #1
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both the changes are good.
However, line 66 coinfloor.GetBalances()
throws an error:
Exception has occurred: TypeError _err_handler() takes 2 positional arguments but 3 were given
check: if this is commented out, then the code runs again.
Please take another look. Note that you were probably trying to use the old v1 api (which no longer allows logins, hence throwing an error) rather than v2. |
I am trying to modify the code for v2, but it is not clear what to enter for the credentials in order to complete the test. The are 4 parameters i have attached in the image from the URL:is this the correct URL ? The core_id of the user:presumably this is what i have labelled (in red) as The cookie, a.k.a API key:which value (in the red boxes) is this please ? passphrase:where does the user get the passphrase from ? |
I used the code with no further modifications with v2 just fine... Run it like this:
Note that currently v2 seems to work just fine with the v1 cookie. The password is the login password to the coinfloor website. |
this works. ammended: Thanks. Can commit to the master now. |
We need someone with write access... |
Additional question. how can the user watch to see if a trade is executed ? presumably it is one of the available methods, so where can one find a list of all of the methods please ? |
See commit messages for each change.