feat: add Earn amount inputs #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| <div className={cn('flex flex-col', className)}> | ||
| <TextInput | ||
| className={cn( | ||
| 'w-full border-[none] bg-transparent font-display text-[2.5rem]', |
There was a problem hiding this comment.
any way to avoid the magic 2.5rem?
brendan-defi
previously approved these changes
Jan 24, 2025
abcrane123
force-pushed
the
alissa.crane/earn-input
branch
from
18df2f1 to
c73c8d4
Compare
0xAlec
previously approved these changes
Jan 24, 2025
dschlabach
reviewed
Jan 24, 2025
| <div className={cn('flex flex-col', className)}> | ||
| <TextInput | ||
| className={cn( | ||
| 'w-full border-[none] bg-transparent font-display text-5xl', |
There was a problem hiding this comment.
Suggested change
| 'w-full border-[none] bg-transparent font-display text-5xl', | |
| 'w-full border-none bg-transparent font-display text-5xl', |
Shouldn't need an arbitrary value
| disabled, | ||
| value, | ||
| onChange, | ||
| 'aria-label': ariaLabel, |
There was a problem hiding this comment.
The only thing that's a little weird about this is exposing a random aria-label to the developer but no other input attributes. Is there a way that we could handle it ourselves?
There was a problem hiding this comment.
well EarnAmountInput shouldn't be used by developer -> they would use the wrapper DepositAmountInput or WithdrawAmountInput that doesn't expose those
abcrane123
force-pushed
the
alissa.crane/earn-input
branch
from
b86a4c5 to
914ea0e
Compare
brendan-defi
approved these changes
Jan 24, 2025
0xAlec
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
EarnAmountInputand wrappers forEarncomponentNotes to reviewers
How has it been tested?