-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Standardize comment format to JSDoc-style syntax #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
force-pushed
the
paul/update-comments
branch
from
January 23, 2025 20:11
024c51d
to
cc16d07
Compare
cpcramer
force-pushed
the
paul/update-comments
branch
from
January 23, 2025 20:23
75f2f55
to
8ba1b4f
Compare
cpcramer
force-pushed
the
paul/update-comments
branch
from
January 24, 2025 00:29
2e03b26
to
2ff584f
Compare
cpcramer
force-pushed
the
paul/update-comments
branch
from
January 24, 2025 00:31
2ff584f
to
1f4eb35
Compare
brendan-defi
previously approved these changes
Jan 24, 2025
toAmount: string; // The amount of the destination token | ||
toAmountUSD: string; // The USD value of the destination token | ||
warning?: QuoteWarning; // The warning associated with the quote | ||
/** The reference amount for the quote */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking: i don't know what a reference amount is, and this comment doesn't help me understand
brendan-defi
previously approved these changes
Jan 24, 2025
cpcramer
force-pushed
the
paul/update-comments
branch
from
January 24, 2025 16:46
518f279
to
32dd367
Compare
cpcramer
force-pushed
the
paul/update-comments
branch
from
January 24, 2025 16:47
32dd367
to
7a1cf59
Compare
dschlabach
approved these changes
Jan 24, 2025
brendan-defi
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
pkg: core
pkg: fund
pkg: identity
pkg: swap
pkg: token
pkg: wallet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
chore: Standardize comment format to JSDoc-style syntax
We're implementing a consistent approach to documentation comments across our codebase. This will improve readability and make our documentation more maintainable.
New Comment Standards
Multi-line comments (
/** */
) for:Single-line comments (
/** */
) for:Regular comments (
//
) for:Example:
Result:
Notes to reviewers
How has it been tested?