feat: add Tabs component #1864
feat: add Tabs component #1864
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/internal/components/Tabs.tsx
Outdated
| <div | ||
| className={cn( | ||
| border.lineDefault, | ||
| 'flex overflow-hidden !border-r-0 !border-l-0 !border-t-0', |
There was a problem hiding this comment.
why do these need to be important?
There was a problem hiding this comment.
when you add the border.lineDefault class it seems to take priority even if you pass border-r-0 after and we need to use border.lineDefault to ensure the border is consistent with rest of theme
There was a problem hiding this comment.
but now that i've refactored i removed and will rely on card to handle border
src/internal/components/Tabs.tsx
Outdated
| className, | ||
| )} | ||
| onClick={handleClick} | ||
| > |
There was a problem hiding this comment.
better for accessibility if this was actually a button, divs aren't focusable elements
| @@ -0,0 +1,70 @@ | |||
| import { fireEvent, render, screen } from '@testing-library/react'; | |||
There was a problem hiding this comment.
This is a nit but could you also change the directory name from components/Tabs to components/tabs? I know we have a couple here that don't follow that pattern, but it's bad practice that we should try and avoid
What changed? Why?
Notes to reviewers
How has it been tested?