Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Popover, DismissableLayer, and FocusTrap primitives in SwapSettings #1856

Merged
merged 5 commits into from
Jan 23, 2025
Merged

feat: Implement Popover, DismissableLayer, and FocusTrap primitives in SwapSettings #1856

merged 5 commits into from
Jan 23, 2025

Conversation

cpcramer
Copy link
Contributor

@cpcramer cpcramer commented Jan 22, 2025 •
edited
Loading

What changed? Why?
Implement Popover, DismissableLayer, and FocusTrap primitives in the SwapSettings component.

Notes to reviewers

How has it been tested?
Tested SwapSettings (mobile and desktop view) and WalletModal in the playground.

@vercel Vercel
Copy link

vercel bot commented Jan 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 11:22pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 11:22pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 11:22pm

@cpcramer cpcramer changed the title Paul/add popover to swap settings feat: Implement Popover primitive in SwapSettings Jan 22, 2025
@cpcramer cpcramer force-pushed the paul/add-popover-to-swap-settings branch from 4ce67ba to 2ed7e9d Compare January 22, 2025 22:49
@cpcramer cpcramer force-pushed the paul/add-popover-to-swap-settings branch from 2ed7e9d to 7615323 Compare January 22, 2025 23:19
@cpcramer cpcramer mentioned this pull request Jan 22, 2025
Merged
@cpcramer cpcramer requested a review from dschlabach January 23, 2025 23:07
@cpcramer cpcramer force-pushed the paul/add-popover-to-swap-settings branch from 8d9eb2a to c275b91 Compare January 23, 2025 23:08
dschlabach
dschlabach previously approved these changes Jan 23, 2025
View reviewed changes
@cpcramer cpcramer requested a review from dschlabach January 23, 2025 23:19
@cpcramer cpcramer merged commit d7a5e68 into main Jan 23, 2025
16 checks passed
@cpcramer cpcramer deleted the paul/add-popover-to-swap-settings branch January 23, 2025 23:45
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcrane123 abcrane123 abcrane123 approved these changes

@dschlabach dschlabach dschlabach approved these changes

Assignees
No one assigned
Labels
pkg: swap
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpcramer @dschlabach @abcrane123