Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: WalletIsland mobile design #1827

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Feat: WalletIsland mobile design #1827

wants to merge 25 commits into from

Conversation

brendan-defi
Copy link
Contributor

@brendan-defi brendan-defi commented Jan 17, 2025 •
edited
Loading

What changed? Why?

  • added BottomSheet internal component
  • implemented BottomSheet in WalletIsland for improved mobile design

iPhone SE
image

iPhone 12 Pro
image

iPhone 14 Pro Max
image

Samsung Galaxy S20 Ultra
image

Notes to reviewers

How has it been tested?

  • playground
  • full test coverage

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:10pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:10pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:10pm

@cpcramer
Copy link
Contributor

This should have trap focus - I think we need to update all bottom sheets with this functionality. Do you want to try and use the TrapFocus primitive here?

@cpcramer
Copy link
Contributor

Also DismissableLayer should work here.

cpcramer
cpcramer reviewed Jan 17, 2025
View reviewed changes
src/styles/constants.ts Outdated Show resolved Hide resolved
@brendan-defi brendan-defi requested a review from cpcramer January 21, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschlabach dschlabach dschlabach approved these changes

@alessey alessey Awaiting requested review from alessey

@abcrane123 abcrane123 Awaiting requested review from abcrane123

@cpcramer cpcramer Awaiting requested review from cpcramer

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
pkg: styles pkg: wallet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brendan-defi @cpcramer @abcrane123 @dschlabach