Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wallet island docs #1801

Draft
wants to merge 150 commits into
base: main
Choose a base branch
from
Draft

feat: wallet island docs #1801

wants to merge 150 commits into from

Conversation

brendan-defi
Copy link
Contributor

What changed? Why?

  • added documentation for WalletIsland
  • updated the Wallet types page with WalletIsland types

Notes to reviewers

How has it been tested?
locally

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 10:31pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 10:31pm


const matrix = useMatrix(value, ecl);
const matrix = useMatrix(ecl, value);
const corners = useCorners(size, matrix.length, bgColor, fillColor, uid);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably also desirable to destructure these params as well given that a few of them are the same type and there are > 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pkg: core pkg: swap pkg: wallet root
Development

Successfully merging this pull request may close these issues.

2 participants