-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set client boundary for Swap
and Token
components
#1800
Draft
dschlabach
wants to merge
2
commits into
dms/use-client-2
Choose a base branch
from
dms/client-swap
base: dms/use-client-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dschlabach
changed the title
fix: set client boundary for
fix: set client boundary for Jan 9, 2025
Swap
Swap
and Token
components
alessey
reviewed
Jan 9, 2025
import { useTheme } from '../../core-react/internal/hooks/useTheme'; | ||
import { background, cn, pressable, text } from '../../styles/theme'; | ||
import type { TokenChipReact } from '../types'; | ||
import { TokenImage } from './TokenImage'; | ||
|
||
/** | ||
* Small button that display a given token symbol and image. | ||
* Small button that displays a given token symbol and image. | ||
* | ||
* WARNING: This component is under development and | ||
* may change in the next few weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
findComponent
has been updated to support RSC payloads from Next. This is only required if the user attempts to composeSwap
with subcomponents (because the children the component receive look slightly different). This is a temporary patch until we migrate to default children.How has it been tested?