Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set client boundary for Swap and Token components #1800

Draft
wants to merge 2 commits into
base: dms/use-client-2
Choose a base branch
from

Conversation

dschlabach
Copy link
Contributor

@dschlabach dschlabach commented Jan 9, 2025

What changed? Why?

Notes to reviewers

  • findComponent has been updated to support RSC payloads from Next. This is only required if the user attempts to compose Swap with subcomponents (because the children the component receive look slightly different). This is a temporary patch until we migrate to default children.

How has it been tested?

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ❌ Failed (Inspect) Jan 9, 2025 9:14pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:14pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:14pm

@dschlabach dschlabach changed the title fix: set client boundary for Swap fix: set client boundary for Swap and Token components Jan 9, 2025
@dschlabach dschlabach marked this pull request as draft January 9, 2025 20:49
import { useTheme } from '../../core-react/internal/hooks/useTheme';
import { background, cn, pressable, text } from '../../styles/theme';
import type { TokenChipReact } from '../types';
import { TokenImage } from './TokenImage';

/**
* Small button that display a given token symbol and image.
* Small button that displays a given token symbol and image.
*
* WARNING: This component is under development and
* may change in the next few weeks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants