feat: Add WalletModal component #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dschlabach
approved these changes
Nov 25, 2024
Comment on lines
+231
to
+235
| wallet: { | ||
| display: 'modal', | ||
| termsUrl: 'https://www.coinbase.com/legal/cookie', // URL to the terms of service for the wallet modal | ||
| privacyUrl: 'https://www.coinbase.com/legal/privacy', // URL to the privacy policy for the wallet modal | ||
| }, |
There was a problem hiding this comment.
do we also want to give playground users the ability to see wallet.display.classic?
There was a problem hiding this comment.
I don't think this is needed because there is no component to display. In classic mode we just connect directly using the CB wallet connector
| @@ -24,6 +24,17 @@ export const config = createConfig({ | |||
| appName: 'OnchainKit', | |||
| preference: 'eoaOnly', | |||
| }), | |||
| walletConnect({ | |||
| projectId: | |||
| ENVIRONMENT_VARIABLES[ENVIRONMENT.WALLETCONNECT_PROJECT_ID] ?? '', | |||
There was a problem hiding this comment.
let's add this env var to site/.env.local.example?
brendan-defi
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
How to use:
Notes to reviewers
How has it been tested?