Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bytes in encode method args not properly handled #138

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

sidt-cb
Copy link
Contributor

@sidt-cb sidt-cb commented Nov 19, 2024

Motivation

Fixes bytes not being properly encoded in method args (see test)

Solution

Currently doesn't work because it creates an empty slice and then copies onto it, but since slice was empty it was not able to receive copied bytes. Updated to create a slice with correct length to hold all decoded bytes

Open questions

@cb-heimdall
Copy link

cb-heimdall commented Nov 19, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@sidt-cb sidt-cb changed the title Sid/fix for bytes argument Fix bytes in encode method args not properly handled Nov 19, 2024
@sidt-cb sidt-cb marked this pull request as ready for review November 19, 2024 23:36
Copy link
Contributor

@yfl92 yfl92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cb-heimdall
Copy link

Review Error for cosmonot1 @ 2024-11-19 23:57:20 UTC
User must have write permissions to review

@yfl92 yfl92 merged commit dc39758 into coinbase:master Nov 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants