Support requesting faucet funds for address #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuga-cb
reviewed
May 2, 2024
| @@ -123,6 +123,10 @@ def to_s | |||
| address_id | |||
| end | |||
|
|
|||
| def faucet | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alex-stone
force-pushed
the
stone/v0.0.3/faucet
branch
4 times, most recently
from
d0c0155 to
bf2c8d1
Compare
alex-stone
commented
May 2, 2024
lib/coinbase.rb
Outdated
| @@ -1,11 +1,14 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module Coinbase; end | |||
|
|
|||
| require_relative 'coinbase/client' | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
yuga-cb
reviewed
May 2, 2024
| # frozen_string_literal: true | ||
|
|
||
| module Coinbase | ||
| class FaucetTransaction |
There was a problem hiding this comment.
These can be follow-ups but:
- Yardocs
- Can we add
wait!andstatusfunctions as we do with Transfer. Possibly an opportunity to factor out an class or module that has those methods
There was a problem hiding this comment.
Added docs fro this class.
The wait! and status functions could be added, but this transaction is only returned after it lands on-chain.
yuga-cb
approved these changes
May 2, 2024
This adds support for requesting faucet funds for a given address. This will be rate limited by the address via the smart contract that backs the faucet and via the API key (1 request every 24 hours). This may be able to be loosened for base-sepolia via the Platform API, but those are the current rate limit parameters.
alex-stone
force-pushed
the
stone/v0.0.3/faucet
branch
from
bf2c8d1 to
e80053d
Compare
yuga-cb
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This adds support for requesting faucet funds for a given address. This will be rate limited by the address via the smart contract that backs the faucet and via the API key (1 request every 24 hours).
This may be able to be loosened for base-sepolia via the Platform API, but those are the current rate limit parameters.
Qualified Impact
This adds a new functionality to an unreleased version. This only impacts the address model.