chore(PSDK-640): add network_id to WalletData #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
alex-stone
reviewed
Dec 18, 2024
lib/coinbase/wallet.rb
Outdated
| @@ -132,14 +132,15 @@ def fetch_wallets_page(page) | |||
| # If nil, a new seed will be generated. If the empty string, no seed is generated, and the Wallet will be | |||
| # instantiated without a seed and its corresponding private keys. | |||
| # with the Wallet. If not provided, the Wallet will derive the first default address. | |||
| def initialize(model, seed: nil) | |||
| def initialize(model, seed: nil, network_id: nil) | |||
There was a problem hiding this comment.
The network_id is also present on the model so we do not need to pass this in:
coinbase-sdk-ruby/lib/coinbase/wallet.rb
Lines 291 to 295 in 6b92ca0
We definitely should serialize it on the way out and we can do a sanity check on the way in too.
This exposes a pretty important concept/flaw that unfortunately we scoped wallets to network.,
alex-stone
approved these changes
Dec 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
It should be clear which saved wallets belong to which networks when you
save_seed/export_datafor a given wallet.Qualified Impact
The network id should always be present, and if it is not, it will simply not be included in the WalletData