Fix user import_wallet #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the user import_wallet to ensure that it uses the memoized wallets_api helper. This currently is returning an error when importing a wallet in the following manner: ```ruby user = Coinbase.default_user cb_wallet = user.import_wallet(Coinbase::Wallet::Data.new(wallet.seed, wallet.wallet_id)) ```
yuga-cb
approved these changes
Apr 30, 2024
jazz-cb
approved these changes
Apr 30, 2024
alex-stone
added a commit
that referenced
this pull request
Apr 30, 2024
This adds a regression test for this PR: #20
alex-stone
added a commit
that referenced
this pull request
Apr 30, 2024
This adds a regression test for this PR: #20
alex-stone
added a commit
that referenced
this pull request
Apr 30, 2024
### What changed? Why? This makes the Coinbase::Wallet::Data object keyword initialized. Since users have to persist this data they will need to rehydrate this. Having the ordering matter makes it more likely for developers to= run into errors (as I did when integrating the SDK). This also adds a regression test for this PR: #20 #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This fixes the user
#import_walletreference forwallets_apito ensure that it uses the memoized helper.Currently this is returning an error since
@wallets_apiis not set unless you initialize a wallet withaddress_count: 0or callinglist_balances.This can be verified with:
Qualified Impact
This impacts wallet import flows