Support invoking smart contracts from MPC Wallets #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-stone
changed the title
alex-stone
requested review from
John-peterson-coinbase and
jazz-cb
and removed request for
John-peterson-coinbase
jazz-cb
reviewed
Sep 5, 2024
| @@ -95,6 +95,34 @@ def trade(amount, from_asset_id, to_asset_id) | |||
| trade | |||
| end | |||
|
|
|||
| # Trades the given amount of the given Asset for another Asset. | |||
There was a problem hiding this comment.
this comment needs an update
jazz-cb
reviewed
Sep 5, 2024
| @@ -162,6 +162,8 @@ def create_contract_invocation_with_http_info(wallet_id, address_id, create_cont | |||
| # http body (model) | |||
| post_body = opts[:debug_body] || @api_client.object_to_http_body(create_contract_invocation_request) | |||
|
|
|||
| puts post_body | |||
This adds support for invoking smart contracts from MPC wallets
and from developer-managed wallets.
```
abi = abi = [
{
inputs: [{internalType: 'address', name: 'recipient', type: 'address'}],
name: 'mint',
outputs: [{internalType: 'uint256', name: '', type: 'uint256'}],
stateMutability: 'payable',
type: 'function'
}
]
invocation = wallet.invoke_contract(contract_address: '0xa82aB8504fDeb2dADAa3B4F075E967BbE35065b9', abi: abi, method: 'mint', args: { recipient: '0x475d41de7A81298Ba263184996800CBcaAD73C0b' })
invocation.wait!
```
alex-stone
force-pushed
the
stone/contract-invocations
branch
from
92f93ff to
6e69178
Compare
jazz-cb
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This adds support for invoking smart contracts from MPC wallets
and from developer-managed wallets.
Qualified Impact
This adds a new feature and should not impact existing features