[PSDK-132] Address.createTransfer / Wallet.createTransfer Implementation #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-peterson-coinbase
force-pushed
the
psdk-132-address-create-transfer
branch
4 times, most recently
from
d7028ec to
4d2e786
Compare
John-peterson-coinbase
changed the title
John-peterson-coinbase
force-pushed
the
psdk-132-address-create-transfer
branch
from
4d2e786 to
dda70e2
Compare
John-peterson-coinbase
changed the title
John-peterson-coinbase
force-pushed
the
psdk-132-address-create-transfer
branch
from
dda70e2 to
a8ee555
Compare
erdimaden
reviewed
May 23, 2024
| transfer: TransferAPIClient; | ||
| baseSepoliaProvider: ethers.Provider; | ||
| }; | ||
| import { WEI_PER_ETHER } from "./constants"; |
There was a problem hiding this comment.
nit: we need to export these constants to the index file. I will create a PR for this.
src/coinbase/wallet.ts
Outdated
Comment on lines
198
to
200
| const key = new ethers.Wallet(convertStringToHex(hdKey.privateKey!)); | ||
| const response = await Coinbase.apiClients.address!.getAddress(this.model.id!, key.address); | ||
| this.cacheAddress(response.data, key); |
There was a problem hiding this comment.
This part has been updated. Could you please pull the latest changes from master?
There was a problem hiding this comment.
Updated and rebased on master
John-peterson-coinbase
force-pushed
the
psdk-132-address-create-transfer
branch
from
a8ee555 to
9023d76
Compare
John-peterson-coinbase
force-pushed
the
psdk-132-address-create-transfer
branch
from
9023d76 to
4038751
Compare
erdimaden
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Address.createTransferWallet.createTransferFollow-ups:
Qualified Impact