adjusted metric name in network layer

coinbase · Dec 15, 2023 · c5917b3 · c5917b3
1 parent 647f259
commit c5917b3
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 10 deletions.
diff --git a/src/storage/networkLayer.ts b/src/storage/networkLayer.ts
@@ -13,6 +13,17 @@ export const DEFAULT_NETWORK_LAYER = {
   sendEvents: NO_OP,
 };
 
+function metricNameEnhancer(
+  metrics: Record<string, unknown>[]
+): Record<string, unknown>[] {
+  metrics.forEach((metric) => {
+    if (metric['metricName']) {
+      metric.metric_name = metric.metricName;
+      delete metric['metricName'];
+    }
+  });
+  return metrics;
+}
 
 /*
  * Schedule an event
@@ -83,7 +94,7 @@ export const sendMetrics = (metrics: Metric[], skipScheduler = false) => {
   const metricEndpoint = `${apiEndpoint}${metricPath}`;
 
   const data = {
-    metricData: JSON.stringify(metrics),
+    metricData: JSON.stringify(metricNameEnhancer(metrics)),
   };
 
   if (skipScheduler) {

diff --git a/src/trackMetric.test.ts b/src/trackMetric.test.ts
@@ -27,7 +27,6 @@ describe('trackMetric', () => {
       tags: {
         locale: '',
         auth: "notLoggedIn",
-        metric_name: "test",
         platform: "web",
         project_name: "testing",
         type: "count",

diff --git a/src/utils/enhancers.test.ts b/src/utils/enhancers.test.ts
@@ -53,7 +53,6 @@ describe('enhance', () => {
             auth: 'notLoggedIn',
             platform: 'unknown',
             project_name: '',
-            metric_name: 'testMetric',
             type: 'count',
             version_name: '',
           },
@@ -75,7 +74,6 @@ describe('enhance', () => {
             auth: 'notLoggedIn',
             platform: 'unknown',
             project_name: '',
-            metric_name: 'testMetric',
             type: 'count',
             version_name: '',
           },
@@ -93,7 +91,6 @@ describe('enhance', () => {
             auth: 'notLoggedIn',
             platform: 'unknown',
             project_name: '',
-            metric_name: 'testMetric',
             type: 'count',
             version_name: '',
           },
@@ -125,7 +122,6 @@ describe('enhance', () => {
             auth: 'notLoggedIn',
             platform: 'unknown',
             project_name: '',
-            metric_name: 'testMetric',
             type: 'count',
             version_name: '',
           },
@@ -145,7 +141,6 @@ describe('enhance', () => {
             auth: 'notLoggedIn',
             platform: 'unknown',
             project_name: '',
-            metric_name: 'testMetric',
             type: 'count',
             version_name: '',
           },
@@ -170,7 +165,6 @@ describe('enhance', () => {
             auth: 'notLoggedIn',
             platform: 'unknown',
             project_name: '',
-            metric_name: 'testMetric',
             type: 'count',
             version_name: '',
           },
@@ -199,7 +193,6 @@ describe('enhance', () => {
           auth: 'notLoggedIn',
           platform: 'unknown',
           project_name: '',
-          metric_name: 'testMetric',
           type: 'count',
           version_name: '',
         },

diff --git a/src/utils/enhancers.ts b/src/utils/enhancers.ts
@@ -83,7 +83,6 @@ const tagsEnhancer = <T extends Metric>(entity: T) => {
     auth: identity.isAuthed() ? 'loggedIn' : 'notLoggedIn',
     platform: config.platform,
     project_name: config.projectName,
-    metric_name: entity.metricName,
     type: entity.metricType,
     ...entity.tags,
     locale: identity.locale ?? '',