Add webhook creation support #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @returns Details of the created webhook | ||
| */ | ||
| export async function createWebhook( | ||
| wallet: Wallet, |
There was a problem hiding this comment.
wallet is an unused parameter. It can be removed and still conform to CdpAction - ref
Comment on lines
13
to
14
| - Sender address for erc20_transfer and erc721_transfer events (listen on transfers originating from this address)) | ||
| - Recipient address for erc20_transfer and erc721_transfer events (listen on transfers being made to this address)) |
There was a problem hiding this comment.
Suggested change
| - Sender address for erc20_transfer and erc721_transfer events (listen on transfers originating from this address)) | |
| - Recipient address for erc20_transfer and erc721_transfer events (listen on transfers being made to this address)) | |
| - Sender address for erc20_transfer and erc721_transfer events (listen on transfers originating from this address) | |
| - Recipient address for erc20_transfer and erc721_transfer events (listen on transfers being made to this address) |
| ), | ||
| ); | ||
|
|
||
| const EventTypeFilter = z.object({ |
There was a problem hiding this comment.
Please add JSDoc string
| case "wallet_activity": | ||
| webhookOptions.eventTypeFilter = { | ||
| addresses: eventTypeFilter.addresses || [], | ||
| wallet_id: "", // this is required by SDK, but can be an empty value |
There was a problem hiding this comment.
Why is this required by the SDK if it is unused?
Can we delete line 84 entirely or must it be specified as ""
There was a problem hiding this comment.
SDK requires this param although it's not required to have a valid value, something we'll look into, but we need this param for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Qualified Impact