Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters to CdpAgentkitWrapper used for monitoring #29

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

adriangomez24
Copy link
Contributor

@adriangomez24 adriangomez24 commented Nov 7, 2024

What changed? Why?

This PR adds parameters to the CdpAgentkitWrapper in the cdp_langchain package used for monitoring. Also modified tests to test for this.

Qualified Impact

If there was an error, then the attributes used to monitor would be incorrect but we prevent against this by using constants. To fix, we should push a new fix.

@cb-heimdall
Copy link

cb-heimdall commented Nov 7, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@adriangomez24 adriangomez24 changed the title Add parameters to CDPAgentkitWrapper used for monitoring Add parameters to CdpAgentkitWrapper used for monitoring Nov 7, 2024
@John-peterson-coinbase John-peterson-coinbase merged commit 097702d into coinbase:master Nov 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants