Complete greedy.py #22
Conversation
| def __str__(self) -> str: | ||
| return "minimize-the-distance-from-avg" | ||
| def lower_bound(self, sums:list, sum_of_remaining_items:float, are_sums_in_ascending_order:bool=False)->float: | ||
| """ |
There was a problem hiding this comment.
There should be an explanation to the algorithm
There was a problem hiding this comment.
I added an explanation for the algorithm.
|
|
||
| # Create a stack whose elements are a partition and the current depth. | ||
| # Initially, it contains a single tuple: an empty partition with depth 0. | ||
| first_bins = binner.new_bins(numbins) | ||
| first_bins = binner.new_bins(numbins) | ||
| if (relative_value): |
There was a problem hiding this comment.
This part of the code should be explained in the documentation
There was a problem hiding this comment.
I added explanation in the documentation.
| if relative_value: | ||
| fast_lower_bound = 0 | ||
| for i in range (numbins): | ||
| fast_lower_bound = fast_lower_bound + max((current_sums[i]-(max(relative_value) * sum(items) - relative_value[i] * sum(items)))-sum(items)*relative_value[i],0) |
There was a problem hiding this comment.
The algorithm should be explained
There was a problem hiding this comment.
Added explanation.
| binner.remove_item_from_bin(best_bins, i, 0) | ||
|
|
||
| for i in range(numbins): | ||
| binner.sums(best_bins)[i] = math.floor(binner.sums(best_bins)[i]) |
There was a problem hiding this comment.
Why are the sums rounded to integers?
There was a problem hiding this comment.
The sums were supposed to be integers the whole time but with relative values - I needed to add a double value into each one of the bins in the beggining of the algorithm. This gave me issues, for example some values were something.00000000000001 so I just turned them into integers after removing the double value.
|
|
||
|
|
||
| if (relative_value): |
There was a problem hiding this comment.
This code should be explained
There was a problem hiding this comment.
Added explanation.
Added MinimizeTheDistanceFromAvg objective to objectives.py and to complete_greedy.py