Add integer_programming_avg.py #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erelsgl
requested changes
Apr 1, 2024
| ): | ||
| """ | ||
| Produce a partition that minimizes the sum of the positive differences from the avg, by solving an integer linear program (ILP). | ||
|
|
There was a problem hiding this comment.
The description of the params in the function documentation does not match the actual params of the function
| verbose=0, | ||
| solver_name=mip.CBC, # passed to MIP. See https://docs.python-mip.com/en/latest/quickstart.html#creating-models. | ||
| # solver_name = mip.GRB, # passed to MIP. See https://docs.python-mip.com/en/latest/quickstart.html#creating-models. | ||
| model_filename=None, |
There was a problem hiding this comment.
Are these two arguments used anywhere? If not, they should be removed.
|
|
||
|
|
||
| model.objective = mip.minimize( | ||
| 0.5 * sum(t_js) |
There was a problem hiding this comment.
Should it always be 0.5, regardless of the number of bins?
There was a problem hiding this comment.
Yes.
sum(t_js) calculates double the difference that we want because it calculates the positive and negative sums (using the absolute value). so we need to devide that into 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integer_programming_avg.py produces a partition that minimizes the sum of the positive differences from the avg, by solving an integer linear program (ILP).