-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug for maximization problems with nonlinear objective #171
Conversation
@@ -294,7 +295,7 @@ bool IpoptProblem::get_starting_point(Index n, [[maybe_unused]] bool init_x, [[m | |||
x[k] = variableLB; | |||
else | |||
x[k] = variableUB; | |||
} | |||
}*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You really mean to comment out the complete code that sets the starting point for Ipopt? Doesn't that mean that Ipopt will start with some uninitialized values for x
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also get a lot of complains from valgrind about using uninitialized data unless I reenable this code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that by adding
ipoptApplication->Options()->SetStringValue("warm_start_init_point", "no", true, true)
that Ipopt would not call this code at all, but am I mistaken?
As far as I understood from the Ipopt documentation, it is not really possible to warm start Ipopt without also providing the z and lambda values. That's why I removed this functionality altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabling warm_start_init_point
will make Ipopt ask for dual values (z, lambda) as well.
But not enabling it will still ask for primal values to start from (x). And the code you disabled was setting x only, as far as I remember.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then I misunderstood. Thanks. I will fix it.
No description provided.