Skip to content

Commit

Permalink
fix: Updated the upload-artifacts workflow to use v4
Browse files Browse the repository at this point in the history
  • Loading branch information
maxemiliang committed Apr 20, 2024
1 parent b278758 commit 22447c9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/benchmarker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ jobs:
run: python main.py -c -s --runs 5

- name: Upload benchmarks
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: benchmarks-${{ github.sha }}
path: ${{ github.workspace }}/shot-benchmarker/benchmarks
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ jobs:
run: ldd SHOT

# This will always run as we always want the test output, however if the files are not found, we just warn the user.
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ always() }}
name: Upload test results
with:
Expand All @@ -302,31 +302,31 @@ jobs:
${{github.workspace}}/build/test-output/*.xml
retention-days: ${{ inputs.retention }}

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ inputs.upload_artifacts }}
name: Upload SHOT Optionsfile
with:
name: shot-optsfile-${{ env.VERSION }}${{ env.ARTIFACT_SUFFIX }}
path: ${{github.workspace}}/build/SHOT.opt
retention-days: ${{ inputs.retention }}

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ inputs.upload_artifacts }}
name: Upload SHOT File
with:
name: shot-binary-${{ env.VERSION }}${{ env.ARTIFACT_SUFFIX }}
path: ${{github.workspace}}/build/SHOT
retention-days: ${{ inputs.retention }}

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ inputs.upload_artifacts }}
name: Upload SHOT Package file
with:
name: shot-package-${{ env.VERSION }}${{ env.ARTIFACT_SUFFIX }}
path: ${{github.workspace}}/build/SHOT-*-Linux.zip
retention-days: ${{ inputs.retention }}

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ inputs.upload_artifacts }}
name: Upload SHOT Libraries
with:
Expand Down

0 comments on commit 22447c9

Please sign in to comment.