Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the clearCurrentTape method #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

osander1
Copy link
Contributor

What it did was zeroing out the ADOLC_CURRENT_DATE_INFOS and ADOLC_CURRENT_TAPE_INFOS_FALLBACK objects. However, it did this in a rather convoluted way: By creating a new object (which is zeroed because its constructor calls initTapeInfos) and then assigning that object.

However, it is much simpler to call initTapeInfos directly for ADOLC_CURRENT_DATE_INFOS(_FALLBACK), and this is what this patch does. The clearCurrentTape method becomes obsolete and is removed.

What it did was zeroing out the ADOLC_CURRENT_DATE_INFOS
and ADOLC_CURRENT_TAPE_INFOS_FALLBACK objects.  However,
it did this in a rather convoluted way:  By creating a new
object (which is zeroed because its constructor calls
initTapeInfos) and then assigning that object.

However, it is much simpler to call initTapeInfos directly
for ADOLC_CURRENT_DATE_INFOS(_FALLBACK), and this is what
this patch does.  The clearCurrentTape method becomes
obsolete and is removed.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants