Draft: Improve cmake buildsystem #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TimSiebert1
reviewed
Nov 26, 2024
| target_link_libraries(adolc PUBLIC Boost::boost Boost::system) | ||
| set(WITH_BOOST 1) | ||
| # TODO: check for header boost/pool/pool_alloc.hpp | ||
| set(USE_BOOST_POOL "#define USE_BOOST_POOL 1") |
There was a problem hiding this comment.
If I got this correctly, boost-pool is used whenever Boost system was found, right? We might have a user-defined option whether to use boost-pool or not.
|
Thank you very much, we really appreciate it! Is it possible for you to update the README accordingly to your changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches are courtesy of Simon Praetorius, thanks!
I marked this pull request as 'draft' because: Originally there was just one commit. I tried to separate into several independent parts for a more readable commit history. I ended up with just two after all. They need a bit of review, or, alternatively, one may just squash them together and merge the whole thing