Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter style #72

Closed
wants to merge 18 commits into from
Closed

Formatter style #72

wants to merge 18 commits into from

Conversation

TimSiebert1
Copy link
Collaborator

@TimSiebert1 TimSiebert1 commented Nov 5, 2024

Hi,

i would like to add a formatter style for 'clang-format' (usable in command line, vscode, emacs, vim, etc..) to unify our code format. The current style is the llvm-style with a different macro indentation.

The PR includes:

  • the '.clang-format' file to define the style
  • an example formatted file 'uni5_for.c' for two different macro indentation options (see commit c097aef and 709b5d0)

I prefer the latter style, but lets discuss it.

@TimSiebert1
Copy link
Collaborator Author

TimSiebert1 commented Nov 5, 2024

Thats interesting. The formatting changes the order of '#include', which results in the definition of 'snprintf' with '_snprintf' on windows systems. This is not allowed anymore and the definition can simply be removed: https://stackoverflow.com/questions/27754492/vs-2015-compiling-cocos2d-x-3-3-error-fatal-error-c1189-error-macro-definiti

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ TimSiebert1
✅ juanlucasrey
❌ Clang Robot


Clang Robot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@TimSiebert1
Copy link
Collaborator Author

I will make a different PR with all formatted files

@TimSiebert1 TimSiebert1 deleted the format branch November 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants