Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erfc partial support #69

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

juanlucasrey
Copy link
Contributor

@juanlucasrey juanlucasrey commented Nov 4, 2024

This implementation has been tested and working with:

-tensor_eval
-tape-less forward order 1
-fov_forward
-zos_forward + fos_reverse

in particular it has NOT been implemented with CUDA, since I cannot it test at the moment.

also, the "(int*)" changes are to avoid clang warnings.

Also worthy of notice, I had to add erfc_op at the end in ADOL-C/src/oplate.h. If I add it right after erf_op, the build fails.

@TimSiebert1
Copy link
Collaborator

Also worthy of notice, I had to add erfc_op at the end in ADOL-C/src/oplate.h. If I add it right after erf_op, the build fails.

The last commit fixes this. I don't know why those numbers are there, but I updated them to the current order and then it builds.

@TimSiebert1
Copy link
Collaborator

Apart from the comment, looks good. Thank you very much!

Could you provide us the tests? I would like to add them to the boost-test file.

@juanlucasrey
Copy link
Contributor Author

Apart from the comment, looks good. Thank you very much!

Could you provide us the tests? I would like to add them to the boost-test file.

I tested with my own repo. I have not tried to build with boost yet, so I have not ran the test suite. I can look into it.

@TimSiebert1 TimSiebert1 merged commit 6ababbb into coin-or:master Nov 8, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants