-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pkg/godot/mirror)!: simplify Mirror
usage by making it generic over artifact.Versioned
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Versioned; impl Versioned
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 62.88% 63.33% +0.45%
==========================================
Files 27 27
Lines 1568 1440 -128
==========================================
- Hits 986 912 -74
+ Misses 457 422 -35
+ Partials 125 106 -19
☔ View full report in Codecov by Sentry. |
coffeebeats
changed the title
refactor(pkg/godot/mirror): simplify
refactor(pkg/godot/mirror)!: simplify Nov 4, 2023
Mirror
usage by making it generic over artifact.Versioned
Mirror
usage by making it generic over artifact.Versioned
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.