Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pkg/godot/mirror)!: simplify Mirror usage by making it generic over artifact.Versioned #128

Merged
merged 12 commits into from
Nov 4, 2023

Conversation

coffeebeats
Copy link
Owner

No description provided.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (3558b69) 62.88% compared to head (6923afb) 63.33%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   62.88%   63.33%   +0.45%     
==========================================
  Files          27       27              
  Lines        1568     1440     -128     
==========================================
- Hits          986      912      -74     
+ Misses        457      422      -35     
+ Partials      125      106      -19     
Files Coverage Δ
internal/client/client.go 66.89% <ø> (ø)
pkg/godot/artifact/archive/archive.go 69.23% <ø> (ø)
pkg/godot/artifact/archive/tarxz.go 55.55% <100.00%> (+1.12%) ⬆️
pkg/godot/artifact/archive/zip.go 53.84% <100.00%> (+1.03%) ⬆️
pkg/godot/artifact/checksum/executable.go 0.00% <ø> (ø)
pkg/godot/artifact/checksum/source.go 0.00% <ø> (ø)
pkg/godot/artifact/executable/executable.go 54.28% <ø> (ø)
pkg/godot/artifact/source/source.go 56.25% <ø> (ø)
pkg/progress/writer.go 100.00% <ø> (ø)
pkg/godot/mirror/mirror.go 79.41% <88.88%> (+5.80%) ⬆️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coffeebeats coffeebeats changed the title refactor(pkg/godot/mirror): simplify Mirror usage by making it generic over artifact.Versioned refactor(pkg/godot/mirror)!: simplify Mirror usage by making it generic over artifact.Versioned Nov 4, 2023
@coffeebeats coffeebeats merged commit 83fb6f1 into main Nov 4, 2023
9 checks passed
@coffeebeats coffeebeats deleted the refactor/mirror branch November 4, 2023 22:58
@coffeebeats coffeebeats mentioned this pull request Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant