Update pipeline to run SonarCloud tasks when succeeded() and not a PR…

… from a fork
coenm · Sep 4, 2024 · ca31109 · ca31109
1 parent 89d2ed9
commit ca31109
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.azuredevops/Pipelines/Templates/prepare-code-analysis.yaml b/.azuredevops/Pipelines/Templates/prepare-code-analysis.yaml
@@ -10,5 +10,5 @@ steps:
     extraProperties: |
       sonar.cs.vstest.reportsPaths=$(Agent.TempDirectory)/**/*.trx
       sonar.cs.opencover.reportsPaths=$(Agent.TempDirectory)/**/*.opencover.xml
-  condition: or( ne(variables['Build.Reason'], 'PullRequest'), eq(variables['System.PullRequest.IsFork'], 'false') )
+  condition: and(succeeded(), or( ne(variables['Build.Reason'], 'PullRequest'), eq(variables['System.PullRequest.IsFork'], 'false') ))
 
diff --git a/.azuredevops/Pipelines/Templates/publish-code-analysis.yaml b/.azuredevops/Pipelines/Templates/publish-code-analysis.yaml
@@ -2,11 +2,11 @@ steps:
 
 - task: SonarCloudAnalyze@2
   displayName: ⚙️ Run Code Analysis
-  condition: or( ne(variables['Build.Reason'], 'PullRequest'), eq(variables['System.PullRequest.IsFork'], 'false') )
+  condition: and(succeeded(), or( ne(variables['Build.Reason'], 'PullRequest'), eq(variables['System.PullRequest.IsFork'], 'false') ))
 
 - task: SonarCloudPublish@2
   displayName: 📢 Publish Quality Gate Result
-  condition: or( ne(variables['Build.Reason'], 'PullRequest'), eq(variables['System.PullRequest.IsFork'], 'false') )
+  condition: and(succeeded(), or( ne(variables['Build.Reason'], 'PullRequest'), eq(variables['System.PullRequest.IsFork'], 'false') ))
 
 - pwsh: |
     dotnet tool install --tool-path . dotnet-reportgenerator-globaltool