Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.29.x] Upgrade karaf to 4.3.10, and json/gson #6819

Open
wants to merge 2 commits into
base: 2.29.x
Choose a base branch
from

Conversation

glenhein
Copy link
Contributor

What does this PR do?

Upgrade gson/json/karaf and related libraries. I bug was found in jetty.xml that was causing the upgraded system to not start-up.

Who is reviewing it?

Select relevant component teams:

Ask 2 committers to review/merge the PR and tag them here.

How should this be tested?

Any background context you want to provide?

What are the relevant tickets?

Fixes: #____

Screenshots

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@glenhein glenhein requested a review from stustison as a code owner November 20, 2024 19:37
@jlcsmith
Copy link
Member

jlcsmith commented Dec 9, 2024

build now

@jlcsmith jlcsmith added the WIP label Dec 9, 2024
@cxddfbot
Copy link

cxddfbot commented Dec 9, 2024

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

cxddfbot commented Dec 9, 2024

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@glenhein glenhein removed the WIP label Dec 12, 2024
@glenhein
Copy link
Contributor Author

FYI: A local full build passes

@jlcsmith jlcsmith changed the title Upgrade karaf to 4.3.10, and json/gson [2.29.x] Upgrade karaf to 4.3.10, and json/gson Dec 12, 2024
@@ -1419,6 +1420,7 @@ public void testDwithinAsNotBeyond() {
* From the Search UI, point-radius uses dwithin. We want dwithin to fallback to intersects as a
* last resort. We buffer the geometry (the point) by the radius and do an intersects.
*/
@Ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these tests not pass? Will this be addressed in a future PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants