-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ID query paging #6742
base: master
Are you sure you want to change the base?
Support ID query paging #6742
Conversation
build now |
@@ -232,6 +229,18 @@ public SourceResponse query(QueryRequest request) throws UnsupportedQueryExcepti | |||
return new SourceResponseImpl(request, responseProps, results, totalHits); | |||
} | |||
|
|||
private boolean shouldDoRealTimeGet(QueryRequest request) throws UnsupportedQueryException { | |||
Query query = request.getQuery(); | |||
if (query.getStartIndex() > 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ I wonder if we should put something into the query response properties to indicate we ignored the real time get request? Or maybe add a debug log instead of this comment to help someone debugging a request?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
build now |
Internal build has been started, your results will be available at build completion. |
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
build now |
Internal build has been started, your results will be available at build completion. |
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
What does this PR do?
Forward port of PR #6737
Who is reviewing it?
@pklinef
@clockard
Select relevant component teams:
@codice/solr
Ask 2 committers to review/merge the PR and tag them here.
@glenhein
@jlcsmith
How should this be tested?
Any background context you want to provide?
What are the relevant tickets?
Fixes: #____
Screenshots
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: